cgit/ui-tree.c, branch v1.2.3A hyperfast web frontend for git repositories written in C.http://git.cetero.st/cgit/atom/ui-tree.c?h=v1.2.32020-03-13T23:48:34Zglobal: use proper accessors for maybe_tree2020-03-13T23:48:34ZJason A. DonenfeldJason@zx2c4.com2020-03-13T02:52:35Zurn:sha1:6a8d6d4b5021af6c90ca0da806691987df449469
A previous commit changed ->tree to ->maybe_tree throughout, which may
have worked at the time, but wasn't safe, because maybe_tree is loaded
lazily. This manifested itself in crashes when using the "follow" log
feature. The proper fix is to use the correct contextual accessors
everytime we want access to maybe_tree. Thankfully, the commit.cocci
script takes care of creating mostly-correct patches that we could then
fix up, resulting in this commit here.
Fixes: 255b78f ("git: update to v2.18.0")
Reviewed-by: Christian Hesse <mail@eworm.de>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
ui-tree: allow per repository override for enable-blame2019-06-25T19:40:59ZChristian Hessemail@eworm.de2019-02-26T16:08:31Zurn:sha1:e1ad15d368bdeb1bffea588b93a29055c5dfb7f4
The blame operation can cause high cost in terms of CPU load for huge
repositories. Let's add a per repository override for enable-blame.
Signed-off-by: Christian Hesse <mail@eworm.de>
git: update to v2.21.02019-06-05T13:37:49ZChristian Hessemail@eworm.de2019-02-24T20:19:46Zurn:sha1:985fba80d06f37fdba5e72d738ce21ab5ab5a76d
Update to git version v2.21.0. Required changes follow upstream commits:
* 6a7895fd8a3bd409f2b71ffc355d5142172cc2a0
(commit: prepare free_commit_buffer and release_commit_memory for
any repo)
* e092073d643b17c82d72cf692fbfaea9c9796f11
(tree.c: make read_tree*() take 'struct repository *')
Signed-off-by: Christian Hesse <mail@eworm.de>
Reviewed-by: John Keeping <john@keeping.me.uk>
global: make 'char *path' const where possible2019-06-05T13:37:49ZChristian Hessemail@eworm.de2019-01-02T16:25:01Zurn:sha1:ccba7eb9d0c43ffe99178ab6632dc3794f887309
Signed-off-by: Christian Hesse <mail@eworm.de>
git: update to v2.19.12018-10-12T21:06:02ZChristian Hessemail@eworm.de2018-08-28T16:27:00Zurn:sha1:2c9f56f3e1c754f60ccffbc6c745b9d5a81ea005
Update to git version v2.19.1. Required changes follow upstream commits:
* commit: add repository argument to get_cached_commit_buffer
(3ce85f7e5a41116145179f0fae2ce6d86558d099)
* commit: add repository argument to lookup_commit_reference
(2122f6754c93be8f02bfb5704ed96c88fc9837a8)
* object: add repository argument to parse_object
(109cd76dd3467bd05f8d2145b857006649741d5c)
* tag: add repository argument to deref_tag
(a74093da5ed601a09fa158e5ba6f6f14c1142a3e)
* tag: add repository argument to lookup_tag
(ce71efb713f97f476a2d2ab541a0c73f684a5db3)
* tree: add repository argument to lookup_tree
(f86bcc7b2ce6cad68ba1a48a528e380c6126705e)
* archive.c: avoid access to the_index
(b612ee202a48f129f81f8f6a5af6cf71d1a9caef)
* for_each_*_object: move declarations to object-store.h
(0889aae1cd18c1804ba01c1a4229e516dfb9fe9b)
Signed-off-by: Christian Hesse <mail@eworm.de>
git: update to v2.18.02018-06-27T16:13:03ZChristian Hessemail@eworm.de2018-06-04T16:49:28Zurn:sha1:255b78ff5291cef79978b025c9872f801de89e23
Update to git version v2.18.0. Required changes follow upstream commits:
* Convert find_unique_abbrev* to struct object_id
(aab9583f7b5ea5463eb3f653a0b4ecac7539dc94)
* sha1_file: convert read_sha1_file to struct object_id
(b4f5aca40e6f77cbabcbf4ff003c3cf30a1830c8)
* sha1_file: convert sha1_object_info* to object_id
(abef9020e3df87c441c9a3a95f592fce5fa49bb9)
* object-store: move packed_git and packed_git_mru to object store
(a80d72db2a73174b3f22142eb2014b33696fd795)
* treewide: rename tree to maybe_tree
(891435d55da80ca3654b19834481205be6bdfe33)
The changed data types required some of our own functions to be converted
to struct object_id:
ls_item
print_dir
print_dir_entry
print_object
single_tree_cb
walk_tree
write_tree_link
And finally we use new upstream functions that were added for
struct object_id:
hashcpy -> oidcpy
sha1_to_hex -> oid_to_hex
Signed-off-by: Christian Hesse <mail@eworm.de>
Reviewed-by: John Keeping <john@keeping.me.uk>
ui-tree: free read_sha1_file() buffer after use2018-06-16T14:20:11ZAndy Greenandy@warmcat.com2018-06-13T02:02:00Zurn:sha1:7708859c4dcebff1e43516c23a8bf80f88fcea35
Free up the buffer allocated in read_sha1_file()
Signed-off-by: Andy Green <andy@warmcat.com>
Signed-off-by: John Keeping <john@keeping.me.uk>
ui-tree: link to blame UI if enabled2017-10-03T18:19:34ZJeff Smithwhydoubt@gmail.com2017-10-02T04:39:09Zurn:sha1:1649afdc9b2febe9ab7e1abe1956c5dcaff93aa1
Create links to the blame page.
Signed-off-by: Jeff Smith <whydoubt@gmail.com>
Reviewed-by: John Keeping <john@keeping.me.uk>
ui-tree: move set_title_from_path to ui-shared2017-10-03T18:19:34ZJeff Smithwhydoubt@gmail.com2017-10-02T04:39:06Zurn:sha1:9337c7ee83221d48d02c3c7b5c9dcbaca23ad92f
The ui-blame code will also need to call set_title_from_path, so go
ahead and move it to ui-shared.
Signed-off-by: Jeff Smith <whydoubt@gmail.com>
Reviewed-by: John Keeping <john@keeping.me.uk>
git: update to v2.142017-08-10T13:58:24ZJeff Smithwhydoubt@gmail.com2017-08-10T00:02:56Zurn:sha1:86a6d358f7a6c2432fde86b9e3c5011a656f20e4
Numerous changes were made to git functions to use an object_id
structure rather than sending sha1 hashes as raw unsigned character
arrays. The functions that affect cgit are: parse_object,
lookup_commit_reference, lookup_tag, lookup_tree, parse_tree_indirect,
diff_root_tree_sha1, diff_tree_sha1, and format_display_notes.
Commit b2141fc (config: don't include config.h by default) made it
necessary to that config.h be explicitly included when needed.
Commit 07a3d41 (grep: remove regflags from the public grep_opt API)
removed one way of specifying the ignore-case grep option.
Signed-off-by: Jeff Smith <whydoubt@gmail.com>