cgit/ui-ssdiff.c, branch v0.12

ui-ssdiff: fix resource leak: free allocation from cgit_fileurl

2015-10-09T11:59:24Z

Coverity-id: 13929 Signed-off-by: Christian Hesse

Avoid non-ANSI function declarations

2015-03-09T16:38:30Z

Sparse says things like: warning: non-ANSI function declaration of function 'calc_ttl' Signed-off-by: John Keeping

Reduce line number bloat, fix hover effect

2014-01-08T13:59:38Z

Currently line numbers look like (for blob view and sdiff respectively): 68 1 name=".." is unnecessary if the id attribute is set (this even applies to IE6), so drop it. (aside, in HTML5, the name attribute is gone.) The line number links can be selected through their parent classes, no need for another class "no", so drop it too. For a file with 2000 lines, this yields a saving of 40% (29% gzipped). While at it, fix the hover effect of line numbers: now the line number get a black background as was intended. Signed-off-by: Peter Wu Signed-off-by: Lukas Fleischer

Always #include corresponding .h in .c files

2013-04-08T13:45:34Z

While doing this, remove declarations from header files where the corresponding definition is declared "static" in order to avoid build errors. Also re-order existing headers in ui-*.c so that the file-specific header always comes immediately after "cgit.h", helping with future consistency. Signed-off-by: John Keeping

ssdiff: correctly manage tab expansion

2013-02-01T12:46:47Z

Previously, replace_tabs("foo\tbar") would become " foobar". Signed-off-by: Julius Plenz Signed-off-by: Jason A. Donenfeld

ssdiff: point line links at exact blob by prepending "id="

2012-11-15T00:03:50Z

Previously, the id_str (i.e. the current or diffed-against commit's SHA1 ID) was simply concatenated to the URL. Now, prepend an "id=" string so that the links actually point to the right blobs and thus the exact lines. Signed-off-by: Julius Plenz Signed-off-by: Jason A. Donenfeld

use correct type for sizeof

2012-03-18T09:26:31Z

**L would have worked well too. Depending on the distribution sizeof *L may return 8 instead of 4. **L is preferable, but since we don't expect this datatype to change very often, sizeof int is less subtle and easier to understand. Signed-off-by: Jamie Couture

ui-ssdiff.c: correct length check for LCS table

2012-01-08T10:01:49Z

Each individual string may be too long for its respective dimension of the LCS table. Signed-off-by: Eric Wong

ui-ssdiff: move LCS table away from the stack

2012-01-03T15:16:01Z

Printing deferred line changes for files containing long lines would cause a segfault. - limit LCS table size: 128x128. - move LCS table to global context: avoid allocating/freeing memory for every deferred line change. Signed-off-by: Jamie Couture

ssdiff: anchors for ssdiff

2011-02-19T13:41:39Z

Emit anchors to the respective revisions in side-by-side diff view Signed-off-by: Bernhard Reutner-Fischer Signed-off-by: Lars Hjemli