cgit/ui-shared.c, branch v1.2.1

Fix gcc 8.1.1 compiler warnings

2018-07-04T01:13:41Z

CC ../shared.o ../shared.c: In function ‘expand_macro’: ../shared.c:487:3: warning: ‘strncpy’ specified bound depends on the length of the source argument [-Wstringop-overflow=] strncpy(name, value, len); ^~~~~~~~~~~~~~~~~~~~~~~~~ ../shared.c:484:9: note: length computed here len = strlen(value); ^~~~~~~~~~~~~ ../ui-shared.c: In function ‘cgit_repobasename’: ../ui-shared.c:136:2: warning: ‘strncpy’ specified bound 1024 equals destination size [-Wstringop-truncation] strncpy(rvbuf, reponame, sizeof(rvbuf)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ CC ../ui-ssdiff.o ../ui-ssdiff.c: In function ‘replace_tabs’: ../ui-ssdiff.c:142:4: warning: ‘strncat’ output truncated copying between 1 and 8 bytes from a string of length 8 [-Wstringop-truncation] strncat(result, spaces, 8 - (strlen(result) % 8)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Jason A. Donenfeld

snapshot: support tar signature for compressed tar

2018-07-03T18:37:44Z

This adds support for kernel.org style signatures where the uncompressed tar archive is signed and compressed later. The signature is valid for all tar* snapshots. We have a filter which snapshots may be generated and downloaded. This has to allow tar signatures now even if tar itself is not allowed. To simplify things we allow all signatures. Signed-off-by: Christian Hesse

extra-head-content: introduce another option for meta tags

2018-07-03T18:37:00Z

This is to support things like go-import meta tags, which are on a per-repo basis. Signed-off-by: Jason A. Donenfeld

global: remove functionality we deprecated for cgit v1.0

2018-06-27T16:13:03Z

The man page states these were deprecated for v1.0. We are past v1.1, so remove the functionality. Signed-off-by: Christian Hesse Reviewed-by: John Keeping

snapshot: strip bit from struct cgit_snapshot_format

2018-06-27T16:13:00Z

We had a static bit value in struct cgit_snapshot_format. We do not rely on it and things can be calculated on the fly. So strip it. Signed-off-by: Christian Hesse

snapshot: support archive signatures

2018-06-27T16:11:19Z

Read signatures from the notes refs refs/notes/signatures/$FORMAT where FORMAT is one of our archive formats ("tar", "tar.gz", ...). The note is expected to simply contain the signature content to be returned when the snapshot "${filename}.asc" is requested, so the signature for cgit-1.1.tar.xz can be stored against the v1.1 tag with: git notes --ref=refs/notes/signatures/tar.xz add -C "$( gpg --output - --armor --detach-sign cgit-1.1.tar.xz | git hash-object -w --stdin )" v1.1 and then downloaded by simply appending ".asc" to the archive URL. Signed-off-by: John Keeping Reviewed-by: Christian Hesse

ui-shared: pass separator in to cgit_print_snapshot_links()

2018-06-27T16:11:19Z

cgit_print_snapshot_links() is almost identical to print_tag_downloads(), so let's extract the difference to a parameter in preparation for removing print_tag_downloads() in the next commit. Signed-off-by: John Keeping Reviewed-by: Christian Hesse

ui-shared: use the same snapshot logic as ui-refs

2018-06-27T16:11:19Z

Make snapshot links in the commit UI use the same prefix algorithm as those in the summary UI, so that refs starting with the snapshot prefix are used as-is rather than composed with the prefix repeated. Signed-off-by: John Keeping Reviewed-by: Christian Hesse

ui-shared: rename parameter to cgit_print_snapshot_links()

2018-06-27T16:11:19Z

This is expected to be a ref not a hex object ID, so name it more appropriately. Signed-off-by: John Keeping Reviewed-by: Christian Hesse

ui-shared: remove unused parameter

2018-06-27T16:11:19Z

The "head" parameter to cgit_print_snapshot_links() is never used, so remove it. Signed-off-by: John Keeping Reviewed-by: Christian Hesse