cgit/ui-refs.c, branch v1.0

ui: show ages in the originator's timezone

2016-02-08T13:22:21Z

This affects the tooltip showing the full time and the case when a date is sufficiently old to be shown in full rather than as an offset. Signed-off-by: John Keeping

ui-shared: remove "format" from cgit_print_age()

2016-02-08T13:19:33Z

We never use any format other than FMT_SHORTDATE, so move that into the function. Signed-off-by: John Keeping

ui-refs: remove useless null check

2015-10-09T08:54:48Z

There is no way that "tag" can be null here. Coverity-id: 13950 Signed-off-by: John Keeping

refs: move layout to page function

2015-08-14T13:46:51Z

Signed-off-by: John Keeping

log: allow users to follow a file

2015-08-12T14:57:46Z

Teach the "log" UI to behave in the same way as "git log --follow", when given a suitable instruction by the user. The default behaviour remains to show the log without following renames, but the follow behaviour can be activated by following a link in the page header. Follow is not the default because outputting merges in follow mode is tricky ("git log --follow" will not show merges). We also disable the graph in follow mode because the commit graph is not simplified so we end up with frequent gaps in the graph and many lines that do not connect with any commits we're actually showing. We also teach the "diff" and "commit" UIs to respect the follow flag on URLs, causing the single-file version of these UIs to detect renames. This feature is needed only for commits that rename the path we're interested in. For commits before the file has been renamed (i.e. that appear later in the log list) we change the file path in the links from the log to point to the old name; this means that links to commits always limit by the path known to that commit. If we didn't do this we would need to walk down the log diff'ing every commit whenever we want to show a commit. The drawback is that the "Log" link in the top bar of such a page links to the log limited by the old name, so it will only show pre-rename commits. I consider this a reasonable trade-off since the "Back" button still works and the log matches the path displayed in the top bar. Since following renames requires running diff on every commit we consider, I've added a knob to the configuration file to globally enable/disable this feature. Note that we may consider a large number of commits the revision walking machinery no longer performs any path limitation so we have to examine every commit until we find a page full of commits that affect the target path or something related to it. Suggested-by: René Neumann Signed-off-by: John Keeping

Avoid non-ANSI function declarations

2015-03-09T16:38:30Z

Sparse says things like: warning: non-ANSI function declaration of function 'calc_ttl' Signed-off-by: John Keeping

tag: reference with "h" instead of "id"

2015-01-19T16:52:10Z

When clicking on "log" from a tag we end up showing the log of whatever branch we used to reach the tag. If the tag doesn't point onto a branch then the tagged commit won't appear in this output. By linking to tags with the head parameter instead of the "id" parameter the log link will show the log of the tag. This is clearly desirable when the tag has been reached from the refs UI and changing the behaviour for tag decorations makes them match branch decorations where log -> decoration -> log shows the log of the decoration. Reported-by: Ferry Huberts Signed-off-by: John Keeping

ui-shared: remove toggle_ssdiff arg to cgit_commit_link()

2014-12-13T11:38:42Z

This argument is never used with a value other than zero, so remove it and simplify the code. Signed-off-by: John Keeping

git: update for git 2.0

2014-06-28T13:14:56Z

prefixcmp() and suffixcmp() have been remove, functionality is now provided by starts_with() and ends_with(). Retrurn values have been changed, so instead of just renaming we have to fix logic. Everything else looks just fine.

ui-refs: simplify cmp_age logic

2014-02-26T15:57:15Z

The check in parse_user that eventually makes it into committer_date and tagger_date is: else if (mode == 3 && isdigit(*p)) { *date = atol(p); mode++; } Since isdigit('-') is always false, date will never be negative. Thus the sign of this function: static int cmp_age(int age1, int age2) { if (age1 != 0 && age2 != 0) return age2 - age1; if (age1 == 0 && age2 == 0) return 0; if (age1 == 0) return +1; return -1; } Will always be the same as the sign of this function: static inline int cmp_age(int age1, int age2) { return age2 - age1; } Signed-off-by: Jason A. Donenfeld Idea-by: Lukas Fleischer