cgit/ui-diff.c, branch v0.9.0.2

Avoid null pointer dereference in cgit_print_diff().

2011-05-23T20:58:35Z

When calling cgit_print_diff() with a bad new_rev and a NULL old_rev, checking for new_rev's parent commit will result in a null pointer dereference. Returning on an invalid commit before dereferencing fixes this. Spotted with clang-analyzer. Signed-off-by: Lukas Fleischer Signed-off-by: Lars Hjemli

ui-diff.c: avoid html injection

2011-03-05T13:13:06Z

When path-filtering was used in commit-view, the path filter was included without proper html escaping. This patch closes the hole. Signed-off-by: Lukasz Janyst Signed-off-by: Lars Hjemli

ssdiff: anchors for ssdiff

2011-02-19T13:41:39Z

Emit anchors to the respective revisions in side-by-side diff view Signed-off-by: Bernhard Reutner-Fischer Signed-off-by: Lars Hjemli

fix errors in printf-style format strings

2010-09-04T15:35:38Z

There were many places where the arguments to a printf-like function did not match the format string. Mostly, these were a missing 'l' flag, but there were three exceptions: - In ui-stats.c, a size_t argument must be printed. C99 has the "%zu" flag for this purpose, but not all compilers support this. Therefore, we mimic what git does - use a NO_C99_FORMAT Makefile variable. - In ui-stats.c, cgit_print_error() was called with a pointer instead of a character. - In ui-log.c, the "columns" argument was never used. Signed-off-by: Mark Lodato

ui-diff: Add link to ignore/show whitespace changes in diffs

2010-07-18T08:54:02Z

Add a link to the "Diffstat" line to ignore/show whitespace changes in the generated diff. To support this, cgit_commit_link() and cgit_diff_link() has learned to preserve the ctx.qry.ignorews variable. Signed-off-by: Johan Herland

Add URL parameter 'ignorews' for optionally ignoring whitespace in diffs

2010-07-18T08:53:48Z

The new ctx.qry.ignorews variable is passed via cgit_diff_files() and cgit_diff_tree() to Git's diff machinery. This is equivalent to passing --ignore-all-space to 'git diff'. Signed-off-by: Johan Herland

ui-diff: Add links to increase/decrease number of context lines in diffs

2010-06-19T11:00:07Z

Add two links to the "Diffstat" line to show more/less context lines in the generated diff. To support this, cgit_commit_link() and cgit_diff_link() has learned to preserve the ctx.qry.context variable. Signed-off-by: Johan Herland Signed-off-by: Lars Hjemli

Add URL parameter 'context' for changing the number of context lines in diffs

2010-06-19T11:00:07Z

The new ctx.qry.context variable is picked up by cgit_print_diff(), and passed via cgit_diff_files() to Git's diff machinery. Signed-off-by: Johan Herland Signed-off-by: Lars Hjemli

ui-diff: Teach diffstat to obey path limit

2010-06-19T08:40:23Z

Also indicate in the diffstat header if a path limit is in effect. Signed-off-by: Johan Herland Signed-off-by: Lars Hjemli

Fixed side-by-side diff bugs related to binary diff and more.

2009-09-16T18:17:56Z

The fixed bugs: * "Binary files differ" did not show up either in unidiff or side-by-side-diff. * Subproject diffs did not work for side-by-side diffs. * The ssdiff link on diff pages did not conserve the path. Signed-off-by: Ragnar Ouchterlony Signed-off-by: Lars Hjemli