cgit/html.c, branch v0.9

Merge branch 'stable'

2011-03-05T13:01:59Z

do not infloop on a query ending in %XY, for invalid hex X or Y

2011-03-05T12:38:34Z

When a query ends in say %gg, (or any invalid hex) e.g., http://git.gnome.org/browse/gdlmm/commit/?id=%gg convert_query_hexchar calls memmove(txt, txt+3, 0), and then returns txt-1, so the loop in http_parse_querystring never terminates. The solution is to make the memmove also copy the trailing NUL. * html.c (convert_query_hexchar): Fix off-by-one error. Signed-off-by: Lars Hjemli

html.c: use '+' to escape spaces in urls

2010-11-09T23:22:41Z

Signed-off-by: Lars Hjemli

prefer html_raw() to write()

2010-09-04T18:30:10Z

To make the code more consistent, and to not rely on the implementation of html(), always use html_raw(...) instead of write(htmlfd, ...). Signed-off-by: Mark Lodato

Merge branch 'stable'

2010-08-29T15:40:51Z

html: fix strcpy bug in convert_query_hexchar

2010-08-29T15:27:40Z

The source and destination strings in strcpy() may not overlap. Instead, use memmove(), which allows overlap. This fixes test t0104, where 'url=foo%2bbar/tree' was being parsed improperly. Signed-off-by: Mark Lodato

html: properly percent-escape URLs

2010-02-09T15:12:43Z

The only valid characters for a URL are unreserved characters a-zA-Z0-9_-.~ and the reserved characters !*'();:@&=+$,/?%#[] , as per RFC 3986. Everything else must be escaped. Additionally, the # and ? always have special meaning, and the &, =, and + have special meaning in a query string, so they too must be escaped. To make this easier, a table of escapes is now used so that we do not have to call fmt() for each character; if the entry is 0, no escaping is needed. Signed-off-by: Mark Lodato

html: make all strings 'const char *'

2010-02-09T04:04:41Z

None of the html_* functions modify their argument, so they can all be 'const char *' instead of a simple 'char *'. This removes the need to cast (or copy) when trying to print a const string. Signed-off-by: Mark Lodato

html.c: use correct escaping in html attributes

2009-01-29T21:21:15Z

First, an apostrophe is not a quote. Second, we also need to escape quotes. And finally, quotes are encoded as '"', not '"e;'. Sighned-off-by: Lars Hjemli

html.c: add html_url_path

2008-10-05T14:52:57Z

This function can be used to generate properly escaped path-components for links. Signed-off-by: Lars Hjemli