cgit/cache.c, branch v0.8

cache.c: use %zd for off_t argument

2008-09-01T20:39:00Z

Signed-off-by: Lars Hjemli

cache.c: fix error checking in print_slot()

2008-05-20T15:56:47Z

The change to print_slot() in cdc6b2f8e7a8d43dcfe0475a9d3498333ea686b8 made the function return correct errno for read errors while ignoring write errors, which is not what was intended. This patch tries to rectify things. Signed-off-by: Lars Hjemli

cache.c: do not ignore errors from print_slot()

2008-05-18T21:59:11Z

If print_slot() fails, the client will be served an inferior response. This patch makes sure that such an error will be returned to main(), which in turn will try to inform about the error in the response itself. The error is also printed to the cache_log, i.e. stderr, which will make the error message appear in error_log (atleast when httpd==apache). Noticed-by: Jim Meyering Signed-off-by: Lars Hjemli

cache.c: use xread()/xwrite() from libgit

2008-05-18T21:34:55Z

These functions handles EINTR/EAGAIN errors during read/write operations, which is something cache.c didn't. While at it, fix a bug in print_slot() where errors during reading from the cache slot might go by unnoticed. Noticed-by: Jim Meyering Signed-off-by: Lars Hjemli

cache.c: make all io-related functions return errno on error

2008-05-18T21:16:50Z

We'll need proper return-values from these functions to make the cache behave correctly (which includes giving proper error messages). Noticed-by: Jim Meyering Signed-off-by: Lars Hjemli

cache.c: read(2) returns -1 on error, not 0

2008-05-18T21:10:05Z

Noticed-by: Jim Meyering Signed-off-by: Lars Hjemli

Add page 'ls_cache'

2008-04-28T10:10:13Z

This new page will list all entries found in the current cache, which is useful when reviewing the new cache implementation. There are no links to the new page, but it's reachable by adding 'p=ls_cache' to any cgit url. Signed-off-by: Lars Hjemli

Redesign the caching layer

2008-04-28T09:32:42Z

The original caching layer in cgit has no upper bound on the number of concurrent cache entries, so when cgit is traversed by a spider (like the googlebot), the cache might end up filling your disk. Also, if any error occurs in the cache layer, no content is returned to the client. This patch redesigns the caching layer to avoid these flaws by * giving the cache a bound number of slots * disabling the cache for the current request when errors occur The cache size limit is implemented by hashing the querystring (the cache lookup key) and generating a cache filename based on this hash modulo the cache size. In order to detect hash collisions, the full lookup key (i.e. the querystring) is stored in the cache file (separated from its associated content by ascii 0). The cache filename is the reversed 8-digit hexadecimal representation of hash(key) % cache_size which should make the filesystem lookup pretty fast (if directory content is indexed/sorted); reversing the representation avoids the problem where all keys have equal prefix. There is a new config option, cache-size, which sets the upper bound for the cache. Default value for this option is 0, which has the same effect as setting nocache=1 (hence nocache is now deprecated). Included in this patch is also a new testfile which verifies that the new option works as intended. Signed-off-by: Lars Hjemli

Add cache.h

2008-03-27T08:22:13Z

The functions found in cache.c are only used by cgit.c, so there's no point in rebuilding all object files when the cache interface is changed. Signed-off-by: Lars Hjemli

Move cgit_repo into cgit_context

2008-02-16T12:56:09Z

This removes the global variable which is used to keep track of the currently selected repository, and adds a new variable in the cgit_context structure. Signed-off-by: Lars Hjemli